deps: Upgrade to DataFusion 54.0.0#4062
Merged
Merged
Conversation
# Conflicts: # native/Cargo.lock
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mbutrovich
changed the title
# Conflicts: # native/Cargo.lock # spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala # spark/src/main/scala/org/apache/comet/serde/math.scala
comphead
reviewed
Jun 19, 2026
| .map(|m| (m.name(), m.as_usize() as i64)) | ||
| .for_each(|(name, value)| { | ||
| native_metric_node.metrics.insert(name.to_string(), value); | ||
| }); |
Contributor
There was a problem hiding this comment.
we prob can simplify this to iterate once
comphead
reviewed
Jun 19, 2026
| withParquetTable(doubleValues.flatMap(m => doubleValues.map(n => (m, n))), "tbl") { | ||
| // expressions with two args | ||
| for (expr <- Seq("atan2", "pow")) { | ||
| for (expr <- Seq("atan2")) { |
Contributor
There was a problem hiding this comment.
pow has correctness issues, the test itself moved to pow.sql
comphead
approved these changes
Jun 19, 2026
mbutrovich
approved these changes
Jun 22, 2026
Contributor
There was a problem hiding this comment.
LGTM! I think we might hit a minor performance regression on TPC-DS, but we'll tackle those here and in DF 54.1.
I tracked that regression in #3978. I can open a new issue to track it after we merge 54.0.
marvelshan
pushed a commit
to marvelshan/datafusion-comet
that referenced
this pull request
Jul 2, 2026
Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: comphead <comphead@ukr.net> Co-authored-by: Oleks V <comphead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3978.
Rationale for this change
DataFusion 54.0.0 is released to crates.io, so this upgrades Comet
mainfrom DataFusion 53.1.0 to 54.0.0. It bumps the deps and applies the DF 54 API and behavior adaptations that we developed and validated on the long-runningdatafusion-54branch.What changes are included in this PR?
53.1.0to54.0.0innative/Cargo.tomlandnative/core/Cargo.toml(datafusion,datafusion-datasource,datafusion-physical-expr-adapter,datafusion-spark,datafusion-functions-nested);Cargo.lockregenerated.as_any()overrides and strip.as_any()from call sites, since the method was dropped fromPhysicalExpr,ScalarUDFImpl,ExecutionPlan, etc. (now reachable via theAnysupertrait).schema_adapter.rs:CastColumnExprwas removed in favor ofCastExpr, which no longer exposesinput_field(). Derive the input field from the childColumnplus the physical file schema, falling back to a synthesized field from the target name and child data type.MemoryPoolimpls (fair_pool,logging_pool,unified_pool): addDisplayandname()to satisfy the new supertrait requirements.pow: markPowunsupported and fall back to Spark, due to a DataFusion power correctness regression (datafusion#22598).WeekDay: DataFusionisodowis1..=7(Monday=1) while SparkWeekDayis0..=6(Monday=0), so subtract 1 fromdatepart(isodow, ...)(datafusion#22599).spark.comet.exec.sortMergeJoinWithJoinFilter.enabled) and mark the config deprecated.CometJoinSuite(full outer SMJ with NULL in join filter).How are these changes tested?
Existing tests, plus the new SPARK-43113 reproducer.