CAMEL-21935: Fix Knative Service missing container image on OpenShift#23804
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
💡 Manual integration tests recommended:
All tested modules (2 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http-log:1.0-SNAPSHOT) instead of the full registry URL when deploying to OpenShift with--trait knative-service.enabled=true089356d392b5(CAMEL-21903) stopped setting the container image on the Container trait, only setting JKube build properties. This works for Deployments (JKube reads the properties), but breaks Knative Services (generated entirely by traits code, not JKube)Root Cause
TraitHelper.configureContainerImage()setsjkube.image.nameandjkube.container-image.nameas Maven build properties but no longer callscontainerTrait.setImage(imageToUse). SinceContainerTrait.apply()only sets the image on the container whencontainerTrait.getImage()is not empty, the Knative Service ends up with no image reference — Knative then resolves the bare artifact name against Docker Hub and fails with 401 Unauthorized.Fix
Re-add
containerTrait.setImage(imageToUse)inTraitHelper.configureContainerImage()so both Deployments and Knative Services get the correct image. The JKube build properties remain as-is for Maven CI/CD overridability.Test plan
KubernetesExportTestassertions fromassertNull(container.getImage())to expect the correct image valueClaude Code on behalf of Claus Ibsen