camel-test-junit6: Make more test configuration methods public for framework extensibility#23729
camel-test-junit6: Make more test configuration methods public for framework extensibility#23729jamesnetherton wants to merge 1 commit into
Conversation
…amework extensibility Changed protected methods to public in CamelContextConfiguration and TestExecutionConfiguration to allow external test frameworks (e.g. Camel Quarkus) to extend base test classes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
|
| */ | ||
| @Deprecated(since = "4.7.0") | ||
| protected TestExecutionConfiguration withCreateCamelContextPerClass(boolean createCamelContextPerClass) { | ||
| public TestExecutionConfiguration withCreateCamelContextPerClass(boolean createCamelContextPerClass) { |
There was a problem hiding this comment.
do we really want to make public a deprecated method?
Shouldn't we try to not use it at all on Camel Quarkus side?
There was a problem hiding this comment.
I'm not sure of the history around it, but the API is somewhat incoherent. withCreateCamelContextPerClass is deprecated. But, isCreateCamelContextPerClass is not deprecated and is referenced in a few places that seem to be critical for the CQ test framework in some scenarios.
3 participants
Motivation for this is to clean up and remove some old hacks in the Camel Quarkus test framework.