Skip to content

ARROW-16977: [R] Update dataset row counting so no integer overflow on large datasets #13514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nealrichardson merged 11 commits into from
Jul 14, 2022
Merged

ARROW-16977: [R] Update dataset row counting so no integer overflow on large datasets #13514

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dbdacb7
Add in r_vec_size for dataset scanner row counting
thisisnic Jul 5, 2022
545e7e9
Update generated file
thisisnic Jul 7, 2022
fc061bc
Swap out int64 for r_vec_size
thisisnic Jul 7, 2022
34e9062
Add tests for Tables and RecordBatches
thisisnic Jul 8, 2022
21337ea
Add test for buffer size method
thisisnic Jul 8, 2022
63c5acc
Remove RecordBatch test
thisisnic Jul 12, 2022
2e19218
Use r_vec_size for more return types
thisisnic Jul 12, 2022
dc92b50
Use map_dbl not map_int for utility functions which use lengths
thisisnic Jul 12, 2022
e8c441a
Test more fields
thisisnic Jul 12, 2022
c71c5e1
Add test for buffers too
thisisnic Jul 13, 2022
c12da57
Remove redundant buffer test
thisisnic Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions r/src/dataset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,8 @@ std::shared_ptr<arrow::Table> dataset___Scanner__TakeRows(
}

// [[dataset::export]]
int64_t dataset___Scanner__CountRows(const std::shared_ptr<ds::Scanner>& scanner) {
return ValueOrStop(scanner->CountRows());
r_vec_size dataset___Scanner__CountRows(const std::shared_ptr<ds::Scanner>& scanner) {
return r_vec_size(ValueOrStop(scanner->CountRows()));
Comment thread
thisisnic marked this conversation as resolved.
}

#endif