Skip to content

Add top level Package.swift file#24

Merged
kou merged 1 commit into
apache:mainfrom
abandy:main
Jun 5, 2025
Merged

Add top level Package.swift file#24
kou merged 1 commit into
apache:mainfrom
abandy:main

Conversation

@abandy

@abandy abandy commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

What's Changed

Adding top level Package.swift file. Arrow and ArrowFlight are included in the top level build.

Closes #15.

@kou

kou commented Jun 5, 2025

Copy link
Copy Markdown
Member

We can register this product to the Swift Package Index by this PR, right?

@abandy

abandy commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

@kou Thanks for adding the issue!

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Can we use this to test all targets?

For example, can we use one swift test instead of https://github.com/apache/arrow/blob/23017e3c48c1033d48674415ee4453476dc61bf3/ci/scripts/swift_test.sh#L35-L47 ?

@kou
kou merged commit 482ecea into apache:main Jun 5, 2025
@kou

kou commented Jun 5, 2025

Copy link
Copy Markdown
Member

@abandy Should we remove Arrow/Package.swift and ArrowFlight/Package.swift because we have the top level Package.swift?

@abandy

abandy commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

@abandy Should we remove Arrow/Package.swift and ArrowFlight/Package.swift because we have the top level Package.swift?

Good question. I wasn't sure if we should remove them yet as they can still be useful if a developer wants to include only Arrow and not ArrowFlight. I was thinking we would remove them once the swift package manager has added a feature for selecting only parts of a library. Please let me know what you think.

@kou

kou commented Jun 6, 2025

Copy link
Copy Markdown
Member

@abandy

abandy commented Jun 7, 2025

Copy link
Copy Markdown
Contributor Author

I found https://github.com/swiftlang/swift-evolution/blob/main/proposals/0450-swiftpm-package-traits.md . Can we use this for this use case?

Yes, I see that it says it has been implemented in 6.1. Once we move to 6.1 then we should definitely take advantage of this feature!

@kou

kou commented Jun 7, 2025

Copy link
Copy Markdown
Member

OK. I've opened #31 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Swift] Publish Arrow Swift to Swift Package Index

2 participants