SnowparkOperator: Add Session Cleanup Test Coverage#68775
Draft
SameerMesiah97 wants to merge 1 commit into
Draft
SnowparkOperator: Add Session Cleanup Test Coverage#68775SameerMesiah97 wants to merge 1 commit into
SameerMesiah97 wants to merge 1 commit into
Conversation
session when the user callable raises an exception. As part of enabling the new coverage, migrate the Snowpark tests away from the removed TaskInstance.run() API and update Snowpark test dependency detection to use the importable Snowpark module.
boring-cyborg
Bot
added
area:providers
provider:snowflake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds test coverage verifying that
SnowparkOperatorcloses the Snowpark session when the user callable raises an exception.The new test exercises the operator's exception path and validates that session cleanup still occurs when execution fails.
Rationale
SnowparkOperatorrelies on afinallyblock to guarantee session cleanup. Explicit coverage of this behavior helps protect against regressions that could leave Snowpark sessions open when user code raises an exception.Notes
While adding the new test, the Snowpark test suite was updated to use
dag_maker.run_ti()instead of the removedTaskInstance.run()API.The Snowpark operator, decorator and util test modules were also updated to use:
pytest.importorskip("snowflake.snowpark")which matches the importable Snowpark module used by the tests. Without this change, the entire test module was being skipped when run locally.
Backwards Compatibility
This change only affects test code and does not modify production behavior or public APIs.