Fix: add _is_isolated_worktree guard to prevent spawn from mutating parent repo checkout - #79237
Open
AnasBabari wants to merge 1 commit into
Open
Fix: add _is_isolated_worktree guard to prevent spawn from mutating parent repo checkout#79237AnasBabari wants to merge 1 commit into
AnasBabari wants to merge 1 commit into
Conversation
…arent repo checkout
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug is that spawn_task/chip creates a worktree dir that is not a real git worktree, so git commands resolve to the parent repo and the harness runs
git checkout -bon the shared main checkout. The provided source lacks the spawn logic, but the reusable isolation check belongs in gitutil.py; we add a helper that asserts a directory is a real isolated worktree (toplevel equals dir and git-dir differs from common-dir) so callers can fail loudly instead of flipping the parent branch.Fixes: #79234
Changes Made
plugins/security-guidance/hooks/gitutil.py