[AAP-78702] Add CleanTextMixin to serializers - #1660
Draft
daphnemaeve wants to merge 6 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://redhat.atlassian.net/browse/AAP-78702
Applies CleanTextMixin (from django-ansible-base) to EDA API serializers so that free-text input (name, description, and similar CharField/TextField values) is validated against the shared allowlist/blocklist rules before being persisted
Wires the mixin into the write-path serializers across activation, credential_input_source, credential_type, decision_environment, eda_credential, event_stream, organization, project, team, and user. Each validate() override now chains to super().validate(...) so the mixin's checks actually run. Fields that legitimately contain non-plain-text content (e.g. extra_var/injectors Jinja2 templates, inputs/metadata credential payloads, token secrets) are excluded via excluded_fields so they aren't rejected as unsafe.
ATF tests: https://gitlab.cee.redhat.com/ansible/testing/eda-test-suite/-/merge_requests/142