Add query count scaling regression test for role-team-access - #1102
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe test suite now checks that team access list query counts do not grow linearly when the number of teams increases from 2 to 20. ChangesTeam access list query coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds a localized regression test for team access query scaling and introduces no production behavior changes; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## devel #1102 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 259 259
Lines 14485 14485
Branches 2218 2218
=======================================
Hits 13728 13728
Misses 757 757
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
AlanCoding
left a comment
There was a problem hiding this comment.
So I think making 20 items in a single test to count queries is probably fine for now. But if these continue to proliferate, at some point we probably need a different strategy so it doesn't blow up our runtime and we can continue to test with increasingly larger sets and more diverse data.
dd34afa to
57c1d10
Compare
6751311 to
ed5e1d7
Compare
Follows up on AAP-78658. Mirrors the existing test_user_access_list_query_count test since role-team-access shares the same AccessListMixin code path. Confirms 0 extra queries going from 2 to 20 teams in the result. Co-authored-by: Cursor <cursoragent@cursor.com>
ed5e1d7 to
e955390
Compare
|
DVCS PR Check Results: PR appears valid (JIRA key(s) found) |
|



Follows up on AAP-78658.
test_team_access_list_query_countmirrors the existingtest_user_access_list_query_counttest, since both endpoints shareAccessListMixin. Confirms 0 extra queries going from 2 to 20 teams in the result — no regression here.How to verify locally
Summary by CodeRabbit