Skip to content

Register read_only_base shortname in managed_role_templates - #1023

Draft
cshiels-ie wants to merge 1 commit into
ansible:develfrom
cshiels-ie:feature/add-read-only-base-managed-role-template
Draft

Register read_only_base shortname in managed_role_templates#1023
cshiels-ie wants to merge 1 commit into
ansible:develfrom
cshiels-ie:feature/add-read-only-base-managed-role-template

Conversation

@cshiels-ie

Copy link
Copy Markdown
Contributor

ManagedReadOnlyBase existed as a class but was not accessible via the ANSIBLE_BASE_MANAGED_ROLE_REGISTRY shortname system, forcing consuming apps to instantiate and register it manually in their AppConfig.ready().

Adding 'read_only_base' to managed_role_templates lets apps declare read-only managed roles through settings alone, consistent with how admin_base and action_base are already exposed.

Assisted-by: Claude Code (claude-sonnet-4-6)

Description

  • What is being changed?
  • Why is this change needed?
  • How does this change address the issue?

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Prerequisites

Steps to Test

Expected Results

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs

ManagedReadOnlyBase existed as a class but was not accessible via the
ANSIBLE_BASE_MANAGED_ROLE_REGISTRY shortname system, forcing consuming
apps to instantiate and register it manually in their AppConfig.ready().

Adding 'read_only_base' to managed_role_templates lets apps declare
read-only managed roles through settings alone, consistent with how
admin_base and action_base are already exposed.

Assisted-by: Claude Code (claude-sonnet-4-6)
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: ec14654e-ac46-45c7-ad9d-719fbe58d7ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

DVCS PR Check Results:

Could not find JIRA key(s) in PR title, branch name, or commit messages

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.70%. Comparing base (6752630) to head (f6c6d03).

@@           Coverage Diff           @@
##            devel    #1023   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files         253      253           
  Lines       13495    13495           
  Branches     2043     2043           
=======================================
  Hits        12781    12781           
  Misses        714      714           
Flag Coverage Δ
py311 94.64% <ø> (ø)
py311-django4 94.68% <ø> (ø)
py311-in-files 94.67% <ø> (ø)
py311-sqlite 93.98% <ø> (+0.02%) ⬆️
py312 94.64% <ø> (ø)
py312-django4 94.68% <ø> (ø)
py312-in-files 94.64% <ø> (ø)
py312-sqlite 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ansible_base/rbac/managed.py 92.68% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6752630...f6c6d03. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant