Allow IPv6 with NetworkInterfaceIPConfiguration

[imrejonk]

SUMMARY

The ip_configurations parameter of the azure_rm_networkinterface module did not allow specifying the IP version, causing the Azure REST API to default to IPv4. Trying to add a public IPv6 address to the network interface would cause this error:

Error creating or updating network interface mynic - Azure Error: IPVersionForPublicIpAndNicIpConfigurationMustMatch
    Message: IP version for publicIPAddress '/subscriptions/[..]/resourceGroups/ansible/providers/Microsoft.Network/publicIPAddresses/mypublicipv6address', version 'IPv6' and network
    interface ipConfiguration '/subscriptions/[..]/resourceGroups/ansible/providers/Microsoft.Network/networkInterfaces/mynic/ipConfigurations/myipv6config', version 'IPv4' must match.

The Azure Python SDK however does allow for a parameter called private_ip_address_version. This commit implements that parameter for the azure_rm_networkinterface module.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

azure_rm_networkinterface

ADDITIONAL INFORMATION

You can now do this:

- name: Create network interfaces
  azure_rm_networkinterface:
    name: 'mynic'
    resource_group: 'myrg'
    location: 'westeurope'
    virtual_network: 'myvirtnet'
    subnet_name: 'mysubnet'
    ip_configurations:
      - name: 'myipv4config'
        primary: True
        public_ip_address_name: 'mypublicipv4address'
        private_ip_address_version: 'IPv4'
      - name: 'myipv6config'
        primary: False
        public_ip_address_name: 'mypublicipv6address'
        private_ip_address_version: 'IPv6'

And I can remove an ugly workaround involving an Ansible command task that just called azure-cli to add IPv6 configurations to network interfaces 😊

[Fred-sun]

@imrejonk Thanks for your contribution. Can you add test cases for the newly added feature? Thank you very much!

[imrejonk]

No problem, I'll add some test cases next week. I just got service principal authentication working for ansible-test and am now doing some trial runs with the existing integration tests.

[imrejonk]

@Fred-sun I've modified the azure_rm_networkinterface integration tests to account for this change and rebased my branch. I also fixed an idempotency issue related to the primary parameter, which was being set from null to False on the second run when the parameter was omitted.

Some things to note:

• I've set the public IP address SKU to 'standard', and the allocation method to 'static'. This is due to limitations in Azure's IPv6 support.
• The total number of public IP addresses being created now comes to four: two for the load balancer (IPv4 and IPv6), and two for the network interface.
• Mixing 'basic' with 'standard' SKUs in a load balancer or NIC configuration is not allowed, so I had to change how IPv4 public addresses were created in the tests.
• I noticed that network security groups and the virtual network were not being removed after running the tests, so I added tasks for cleaning them up.

Let me know if this is sufficient, and if not, what types of additional tests you would like to see.

[imrejonk]

@Fred-sun here you go, style issues fixed.

[Fred-sun]

@Fred-sun here you go, style issues fixed.

@imrejonk Merger will be promoted in the near future. Thank you very much!

[xuzhang3]

LGTM