Skip to content

add new paramter node_labels for agent_pool - #577

Merged
xuzhang3 merged 2 commits into
ansible-collections:devfrom
Fred-sun:add_node_labels_aks
Jul 9, 2021
Merged

add new paramter node_labels for agent_pool#577
xuzhang3 merged 2 commits into
ansible-collections:devfrom
Fred-sun:add_node_labels_aks

Conversation

@Fred-sun

@Fred-sun Fred-sun commented Jul 7, 2021

Copy link
Copy Markdown
Collaborator
SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@Fred-sun Fred-sun added enhancement New feature or request medium-priority Medium priority working In trying to solve, or in working with contributors labels Jul 7, 2021
@Fred-sun Fred-sun added ready-for-review The PR is ready to be reviewed and merged. and removed working In trying to solve, or in working with contributors labels Jul 8, 2021
@xuzhang3

xuzhang3 commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

LGTM

@xuzhang3
xuzhang3 merged commit c247487 into ansible-collections:dev Jul 9, 2021
Fred-sun added a commit to Fred-sun/ansible_collections_azure that referenced this pull request Aug 11, 2021
* add new paramter node_labels for agent_pool

* remove space

Add return value for azure_rm_containerregistry idempotent test (ansible-collections#578)

* Add return value for azure_rm_containerregistry idempotent test

* fix sanity error:

* remove require set

azure_rm_roleassignment bugfix (ansible-collections#464)

* pushing fixes.

* whitespace

* whitespace

* Update aliases

* add assignee filter to triplet lookup

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

azure_rm_aks: support system-assigned (managed) identity, (ansible-collections#514)

* azure_rm_aks: make linux_profile and service_principal optional, support system-assigned (managed) identity

* azure_rm_aks: adjust docs formatting

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* azure_rm_aks: add a test for the minimal parameters cluster definition

* azure_rm_aks: fix sanity-checks / pep8 requirements

* Add instructions for tests / sanity checks

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

Upddate test case (ansible-collections#585)
@Fred-sun
Fred-sun deleted the add_node_labels_aks branch December 31, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request medium-priority Medium priority ready-for-review The PR is ready to be reviewed and merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants