Add availability zones to azure_rm_virtualmachine_info module - #523
Merged
haiyuazhang merged 3 commits intoMay 13, 2021
Merged
Conversation
|
@ChandlerSwift Thanks for your contribution! I will review and push for merged! |
Collaborator
|
@ChandlerSwift Thanks for your contribution! Would you help to add test case for the new change? Thank you very much! |
Fred-sun
reviewed
May 12, 2021
haiyuazhang
force-pushed
the
dev
branch
2 times, most recently
from
May 12, 2021 11:26
2281f46 to
8dfc8ed
Compare
ChandlerSwift
force-pushed
the
add-availability-zone-to-vm-info
branch
from
May 12, 2021 21:04
63185e1 to
1e2d23c
Compare
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fred-sun
reviewed
May 13, 2021
| returned: always | ||
| type: str | ||
| sample: Standard_D4 | ||
| zones: |
Collaborator
There was a problem hiding this comment.
Please add sample for this return value!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds availability zone info to the
azure_rm_virtualmachine_infomodulefixes #522
This is, in a way, an extension of #243.
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine_info
ADDITIONAL INFORMATION
With this PR, output looks like:
TASK [test : debug] ************************************************************************************************************** task path: /ansible/roles/test/tasks/main.yml:27 ok: [...] => { "vm_info": { "changed": false, "failed": false, "vms": [ { "admin_username": "...", "boot_diagnostics": { "console_screenshot_uri": "...", "enabled": true, "serial_console_log_uri": "...", "storage_uri": "..." }, "data_disks": [ { "caching": "ReadWrite", "disk_size_gb": 128, "lun": 0, "managed_disk_type": "Premium_LRS" } ], "id": "...", "image": { "id": "..." }, "location": "...", "name": "...", "network_interface_names": [ "..." ], "os_disk_caching": "ReadWrite", "os_type": "Linux", "power_state": "running", "resource_group": "...", "state": "present", "tags": { ... }, - "vm_size": "..." + "vm_size": "...", + "zones": [ + "2" + ] } ] } }