Skip to content

azure_rm_aks: cluster client & models API version - #497

Merged
xuzhang3 merged 12 commits into
ansible-collections:devfrom
MarcGi:update_aks_api_version
Jun 30, 2021
Merged

azure_rm_aks: cluster client & models API version#497
xuzhang3 merged 12 commits into
ansible-collections:devfrom
MarcGi:update_aks_api_version

Conversation

@MarcGi

@MarcGi MarcGi commented Apr 18, 2021

Copy link
Copy Markdown
Contributor
SUMMARY

Fixes #489

  • Updated the AKS managed cluster client & models API version from 2019-04-01 to 2020-04-01
  • Made required changes to properties based on API version.
  • Updated the relevant documentation
  • Added changeable properties to the update agent pool method that were previously missing
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • azure_rm_aks
  • azure_rm_aks_info
  • azure_rm_aksupgrade_info
ADDITIONAL INFORMATION

Breaking Changes:

azure_rm_aks:

  • An agent_pool_profile now requires the 'mode' property

azure_rm_aksupgrade_info:

  • upgrades.azure_aks_upgrades.agent_pool_profiles[n].kubernetes_version no longer returns an available upgrade version if the control plane needs updated first

Command Example:

 - name: Create an AKS instance
   azure_rm_aks:
     name: "aks{{ rpfx }}"
     resource_group: "{{ resource_group }}"
     location: eastus
     dns_prefix: "aks{{ rpfx }}"
     kubernetes_version: "{{ versions.azure_aks_versions[0] }}"
     service_principal:
         client_id: "{{ azure_client_id }}"
         client_secret: "{{ azure_secret }}"
     linux_profile:
         admin_username: azureuser
         ssh_key: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDSPmiqkvDH1/+MDAVDZT8381aYqp73Odz8cnD5hegNhqtXajqtiH0umVg7HybX3wt1HjcrwKJovZURcIbbcDvzdH2bnYbF93T4OLXA0bIfuIp6M86x1iutFtXdpN3TTicINrmSXEE2Ydm51iMu77B08ZERjVaToya2F7vC+egfoPvibf7OLxE336a5tPCywavvNihQjL8sjgpDT5AAScjb3YqK/6VLeQ18Ggt8/ufINsYkb+9/Ji/3OcGFeflnDXq80vPUyF3u4iIylob6RSZenC38cXmQB05tRNxS1B6BXCjMRdy0v4pa7oKM2GA4ADKpNrr0RI9ed+peRFwmsclH test@ansible
     agent_pool_profiles:
         - name: default
           count: 1
           vm_size: Standard_B2s
           type: VirtualMachineScaleSets
           mode: System
           max_pods: 42
           availability_zones:
             - 1
             - 2
     node_resource_group: "node{{ noderpfx }}"
     enable_rbac: yes
     network_profile:
         load_balancer_sku: standard
   register: output

@MarcGi

MarcGi commented Apr 18, 2021

Copy link
Copy Markdown
Contributor Author

Hi @Fred-sun, Could you please review this when you have the time? Thank you very much!

@Fred-sun

Copy link
Copy Markdown
Collaborator

Hi @Fred-sun, Could you please review this when you have the time? Thank you very much!

@MarcGi Thanks for your contribution! I'm working in!

Comment thread plugins/modules/azure_rm_aks.py Outdated
@Fred-sun Fred-sun added bug Something isn't working medium-priority Medium priority new-feature This issue/PR is related to a new feature introduced. labels Apr 19, 2021
MarcGi and others added 2 commits April 19, 2021 09:20
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun Fred-sun removed the bug Something isn't working label Apr 20, 2021
@haiyuazhang
haiyuazhang force-pushed the dev branch 2 times, most recently from 2281f46 to 8dfc8ed Compare May 12, 2021 11:26
@haiyuazhang haiyuazhang changed the title Updated AKS managed cluster client & models API version azure_rm_aks: cluster client & models API version May 17, 2021
Comment thread plugins/modules/azure_rm_aks.py Outdated
@Fred-sun Fred-sun added the ready-for-review The PR is ready to be reviewed and merged. label Jun 29, 2021
@xuzhang3

Copy link
Copy Markdown
Contributor

LGTM

@xuzhang3
xuzhang3 merged commit b9582c2 into ansible-collections:dev Jun 30, 2021
Fred-sun added a commit to Fred-sun/ansible_collections_azure that referenced this pull request Aug 11, 2021
…s#497)

* Updated managedcluster client to 2020-04-01

* Added mode to azure_rm_aks AgentPoolProfiles

This change was required as of the 2020-03-01 AgentPoolApi Version(Azure/AKS#1602 (comment))

* Added integration tests for switching pool mode

* Update plugins/modules/azure_rm_aks.py

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Update plugins/modules/azure_rm_aks.py

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium-priority Medium priority new-feature This issue/PR is related to a new feature introduced. ready-for-review The PR is ready to be reviewed and merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Idea] Upgrade Managed Cluster Client Api Version To 2020-04-01

3 participants