Skip to content

Migrate missing doc_fragments that went missing to this collection - #115

Merged
haiyuazhang merged 2 commits into
ansible-collections:devfrom
AlanCoding:migrate_doc_fragment
May 15, 2020
Merged

Migrate missing doc_fragments that went missing to this collection#115
haiyuazhang merged 2 commits into
ansible-collections:devfrom
AlanCoding:migrate_doc_fragment

Conversation

@AlanCoding

Copy link
Copy Markdown
Contributor
SUMMARY

See issue #103

This pulls in:

https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/plugins/doc_fragments/azure.py
https://github.com/ansible/ansible/blob/stable-2.9/lib/ansible/plugins/doc_fragments/azure_tags.py

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

doc_fragments/azure.py
doc_fragments/azure_tags.py

ADDITIONAL INFORMATION

I tried to do due diligence asking here:

ansible/ansible#67684 (comment)

About whether or not the current code in this collection will be allowed to work. There was some confusion on that point, but they have clearly answered that nothing is planned that will support the non-FQCN doc fragment. I see no way to get this fixed in any reasonable timeframe other than the collection, itself, making this change.

Example of testing this:

ANSIBLE_COLLECTIONS_PATHS=../../.. ansible-doc azure.azcollection.azure_rm_image

This renders correctly (using Ansible devel branch), and makes use of both doc fragments. I have also tested the inventory plugin with ansible-inventory.

Ping @gundalow, because I know he has tried to do a sweep to check for items that went missing in the great collection migration. This isn't the first time this kind of situation has happened. Doc fragments were not around when several collections started out, so there's a clear story of how it got here.

if you consult the Ansible core file (the current file) .github//BOTMETA.yml, then you will find:

  lib/ansible/plugins/doc_fragments/azure.py:
    migrated_to: azure.azcollection
  lib/ansible/plugins/doc_fragments/azure_tags.py:
    migrated_to: azure.azcollection

So clearly it thinks that these files moved here.

@Fred-sun

Copy link
Copy Markdown
Collaborator

Update document, ready_for_review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants