fix(core): make workspace destroy idempotent - #44769
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
workspace.destroypostcondition-idempotent and report{ destroyed: boolean }:truewhen this call removed an existing workspace,falsewhen it was already absent.Durable callers retry the same workspace ID after failures and crashes. If teardown succeeded but its acknowledgement was lost, the old
Workspace.NotFoundresponse wedged that retry loop and forced every caller to special-case absence.How
Workspace.NotFoundfor operations where absence breaks the request, including connect and provision.workspace.destroyendpoint, thread the result through the server and SDK, and regenerate Promise and Effect clients.Testing
bun run testinpackages/core(2239 passed, 16 skipped)bun run testinpackages/server(27 passed)bun run testinpackages/sdk(23 passed)bun test test/promise.test.ts --test-name-pattern 'workspace.destroy returns the transition result'inpackages/clientbun typecheckinpackages/core,packages/protocol,packages/server,packages/client, andpackages/sdkbun turbo typecheck --concurrency=3(32 packages passed)