Skip to content

fix(app): prioritize shortcuts in terminal - #35668

Merged
Brendonovich merged 1 commit into
devfrom
terminal-close-shortcut
Jul 7, 2026
Merged

fix(app): prioritize shortcuts in terminal#35668
Brendonovich merged 1 commit into
devfrom
terminal-close-shortcut

Conversation

@Brendonovich

@Brendonovich Brendonovich commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • dispatch app shortcuts during keyboard capture so focused terminals cannot swallow them
  • support contextual shortcut collisions while preserving global fallbacks
  • close the active terminal with Mod+W when terminal input is focused
  • collapse the terminal pane after closing its final tab

Validation

  • bun typecheck in packages/app
  • bun test --preload ./happydom.ts ./src/context/command.test.ts ./src/context/command-keybind.test.ts ./src/context/terminal.test.ts
  • repository pre-push typecheck

@Brendonovich
Brendonovich requested a review from Hona as a code owner July 7, 2026 06:32
@Brendonovich
Brendonovich enabled auto-merge (squash) July 7, 2026 06:38
@Brendonovich
Brendonovich merged commit 65fd2e5 into dev Jul 7, 2026
@Brendonovich
Brendonovich deleted the terminal-close-shortcut branch July 7, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Couldn't load reviewers.

Assignees

Couldn't load assignees.