fix: plan-build switch reminder spam, provider config limit optional#31897
Closed
LifetimeVip wants to merge 2 commits into
Closed
fix: plan-build switch reminder spam, provider config limit optional#31897LifetimeVip wants to merge 2 commits into
LifetimeVip wants to merge 2 commits into
Conversation
…anning all history
… cap - provider.ts: limit context/output now optional (your 1M context config no longer fails) - transform.ts: remove 32K OUTPUT_TOKEN_MAX hard cap - migrate.ts: handle undefined limit fields
github-actions
Bot
added
the
needs:compliance
This was referenced Jun 11, 2026
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
@thdxr @jlongster @rekram1-node @simonklee @Hona these 8 PRs together fix 30 open issues (compaction context loss, Windows encoding, tool error handling, security, etc.). All are mergeable with no conflicts. Would appreciate a review when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31763 #31780
Type of change
What does this PR do?
Fix plan-to-build switch reminder firing every turn and provider config schema requiring limit.output when limit is present.
How did you verify your code works?
Tested in custom fork, verified reminder fires only once and config loads without limit.output.
Screenshots / recordings
N/A - logic change, not UI
Checklist