fix: MCP env leak, electron-builder OPENCODE_CHANNEL default to prod#31894
Closed
LifetimeVip wants to merge 2 commits into
Closed
fix: MCP env leak, electron-builder OPENCODE_CHANNEL default to prod#31894LifetimeVip wants to merge 2 commits into
LifetimeVip wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
needs:compliance
This was referenced Jun 11, 2026
Open
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
@thdxr @jlongster @rekram1-node @simonklee @Hona these 8 PRs together fix 30 open issues (compaction context loss, Windows encoding, tool error handling, security, etc.). All are mergeable with no conflicts. Would appreciate a review when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31777 #31778
Type of change
What does this PR do?
Fix MCP subprocess receiving full process.env (API key leakage) and electron-builder test leaving OPENCODE_CHANNEL env dirty.
How did you verify your code works?
Tested in custom fork, verified MCP env is filtered to safe vars only.
Screenshots / recordings
N/A - logic change, not UI
Checklist