fix: tool error handling - V1 errors not silent, proper error propagation, read-before-edit enforcement#31892
Closed
LifetimeVip wants to merge 6 commits into
Closed
fix: tool error handling - V1 errors not silent, proper error propagation, read-before-edit enforcement#31892LifetimeVip wants to merge 6 commits into
LifetimeVip wants to merge 6 commits into
Conversation
Also adjust V2 toModelOutput format to prevent bypassing read-before-edit
- subagent-permissions.ts: forward ALL deny rules not just edit - tool.ts: catch thrown Errors as ToolFailure instead of crashing session
github-actions
Bot
added
the
needs:compliance
This was referenced Jun 11, 2026
edit.ts: oldString not found error does not include file content, causing AI to guess blindly
#30863
Closed
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
@thdxr @jlongster @rekram1-node @simonklee @Hona these 8 PRs together fix 30 open issues (compaction context loss, Windows encoding, tool error handling, security, etc.). All are mergeable with no conflicts. Would appreciate a review when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30853 #30863 #30867 #31772
Type of change
What does this PR do?
Fix V1 tool errors silently swallowed by Effect.orDie, Question tool bypassing read-before-edit, read.ts using Effect.die instead of Effect.fail, and edit.ts oldString error missing file content.
How did you verify your code works?
Tested in custom fork with verified before/after behavior.
Screenshots / recordings
N/A - logic change, not UI
Checklist