fix(@angular/build): treat empty browsers array as undefined in unit-test builder#32679
Conversation
…test builder Ensure that an empty `browsers` array is treated as `undefined` during the option normalization process. This allows the unit-test builder to properly fall back to the Node.js/jsdom environment for Vitest, and allows the Karma runner to use its default configuration. Closes angular#32652
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where an empty browsers array in the unit-test builder options was not handled as an absence of a value. The change correctly treats an empty array as undefined, ensuring the builder falls back to its default behavior. The implementation is sound. I have added one comment pointing out that while this change is a good safeguard, the situation it handles might indicate an underlying issue with schema validation that could be investigated separately.
|
@alan-agius4 can this be applied to 20.x as well? |
|
Version 20 is LTS. No new bug fixes, just security fixes. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Ensure that an empty
browsersarray is treated asundefinedduring the option normalization process. This allows the unit-test builder to properly fall back to the Node.js/jsdom environment for Vitest, and allows the Karma runner to use its default configuration.Closes #32652