feat (mongoose): use mongoose-bird to promisify the mongoose API

[pentateu]

No description provided.

[kingcody]

Changing this line to: var validationError = function(res, code) { should resolve your build error.

[pentateu]

cool.thanks for the heads up.

[kingcody]

@pentateu not a big deal, but chai-as-promised was implemented in canary. Your user.mode.spec.js could be tweaked like so:

it('should fail when saving a duplicate user', function() {
  return user.saveAsync()
    .then(function() {
      var userDup = new User(user);
      return userDup.saveAsync();
    })
    .should.be.rejected;
});

it('should fail when saving without an email', function() {
  user.email = '';
  return user.saveAsync().should.be.rejected;
});

[kingcody]

@pentateu what are your thoughts on mongoomise?

[pentateu]

@kingcody I was not aware of mongoomise when I did mongoose-bird. It looks good.
I like that with mongoomise you can choose any promise library you want.
With mongoomise you need to load your modals first and I think this is an inconvenience.
With mongoose-bird you don't have this problem, you load mongoose using mongoose-bird and everything else after that is promisified, including any model you load afterwards.
I believe that mongoomise could be tweaked to work as mongoose-bird so you don't need to load the models first.

Anyway having options is good, but is comes with a cost of complexity which in the case of generator is a relevant topic. mongoomise benchmark also points to blubird as having the best performance. That is why I have chosen to use blubird.

In summary I would stick with mongoose-bird for now.

[DaftMonk]

Looks great. Much easier to read these methods when they're using promises.

[DaftMonk]

Could you update it against canary?

[pentateu]

Yeah.. I'll find some time this weak to rebase on Canary and also do the unit test updates suggested using chai-as-promise

[kingcody]

@pentateu please correct me if I'm wrong, but shouldn't this be:

return updated.saveAsync()
  .then(function() {
    return updated;
  });

I actually had problems with passing a callback. Perhaps I was doing something wrong?

[pentateu]

yes :-) I have it fixed now.

[kingcody]

@pentateu feel free to take a look at #520. I rebased your PR onto canary and adjusted a few things. If you'd like to use 520, just let me know.

Thanks

[pentateu]

Hi @DaftMonk I have rebased the PR on canary ..

I had a look on PR #520 by @kingcody , but I noticed that there were a few <% if (filters.mongoose) { %> missing from the templates.

[kingcody]

@pentateu I updated the line comments in #520 to indicate where and why they were moved.

[kingcody]

Also @pentateu your build is failing because canary no longer uses should.js and instead uses Chai assertions. If you look in mocha.conf.js you should see where chai.should() is initialize as well as defining expect, assert, and sinon as globals for the tests.

You should be able to simply remove var should = require('should'); from the tests to correct the issue.

[pentateu]

@kingcody thanks for the heads-up.

[JaKXz]

This should be closed in favour of #520, yes?

[pentateu]

Sorry for the delay.. I have fixed the issues with lodash not being inside the mongoose condition.

[pentateu]

@JaKXz I'm happy either way.. merging this one or merging #520 will have the same result.

[DaftMonk]

Closed with #520