fix(app-config): Use parentheses to fix string concat in config#469
Merged
DaftMonk merged 1 commit intoAug 23, 2014
Merged
Conversation
Member
Author
|
Wow, I really gotta remember: No |
Changes: - wrap `process.env.DOMAIN || ''` in parentheses to correct the order of the OR operator and string concat Closes angular-fullstack#466
kingcody
force-pushed
the
fix/order-of-operations
branch
from
6ef87bf to
c6a50ce
Compare
kingcody
changed the title
DaftMonk
added a commit
that referenced
this pull request
Aug 23, 2014
fix(app-config): Use parentheses to fix string concat in config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
process.env.DOMAIN || ''in parentheses to correct the order of the OR operator and string concatCloses #466