Chore: update grunt deps#1168
Merged
Merged
Conversation
Collaborator
|
oh jeez, why not have these all as one commit? |
Member
Author
|
I was going to, but I didn't know if we wanted to record it in the |
Member
Author
|
@Awk34 it's your call, I don't really care; can just as easily squash it. |
Collaborator
|
Yeah, squash em. |
kingcody
force-pushed
the
chore/update-grunt-deps
branch
from
2b79a87 to
db35124
Compare
Member
Author
|
|
Collaborator
Hah, what a nerd! Do you think you could just make some notes (here, or body of commit message, etc) about the breaking changes/etc from some of the updated packages? |
Member
Author
|
There shouldn't be any BC's. Also, not sure how all these other commits got here. I'll rebase... |
kingcody
force-pushed
the
chore/update-grunt-deps
branch
from
db35124 to
940e08a
Compare
Collaborator
|
Oh, I meant the changes to the |
Changes: * `grunt-contrib-watch` now uses `spawn: false` instead of `nospawn: true` @see https://github.com/gruntjs/grunt-contrib-watch#optionsspawn * `grunt-contrib-imagemin` now minifies svg files, remove `grunt-svgmin` @see https://github.com/gruntjs/grunt-contrib-imagemin#imagemin-task
kingcody
force-pushed
the
chore/update-grunt-deps
branch
from
940e08a to
aa6047e
Compare
Member
Author
|
There we go. |
Collaborator
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
grunt-contrib-watchnow usesspawn: falseinstead ofnospawn: true-- see: https://github.com/gruntjs/grunt-contrib-watch#optionsspawn
grunt-contrib-imageminnow minifies svg files, removegrunt-svgmin-- see: https://github.com/gruntjs/grunt-contrib-imagemin#imagemin-task