Pass data using 'json' so it gets encoded and correctly mimetype-d.#29
Closed
elo80ka wants to merge 1 commit intoandela-sjames:masterfrom
Closed
Pass data using 'json' so it gets encoded and correctly mimetype-d.#29elo80ka wants to merge 1 commit intoandela-sjames:masterfrom
elo80ka wants to merge 1 commit intoandela-sjames:masterfrom
Conversation
|
Changes Unknown when pulling 948bbd9 on elo80ka:master into ** on andela-sjames:master**. |
Owner
|
@elo80ka thanks for reaching out, this is a better modification as opposed to encoding it manually. Please, can you raise a Pull request to the Develop branch so that it can be merged and updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi...thanks for releasing this.
While using the latest version (1.2.4) in a project with Python 3.6, I noticed that trying to create plans kept returning a
400: Bad Request. Specifically:Enabling logging for
requests, I discovered that theContent-typewas being set toapplication/x-www-urlencoded, and the data posted as key/value pairs, which Paystack doesn't support. This appears to be the default behaviour forrequests.Changing the
dataparameter inpaystackapi.base.PaystackRequests._requesttojsonworks (it correctly sets theContent-typetoapplication/jsonand JSON-encodes the payload), and has been supported since version 2.4.2. I'm a bit confused though - is this a Python 3.6-only issue? Or are you manually JSON-encoding your data somehow?