Add method and class IDs to channel errors - #447
Merged
Conversation
Contributor
Author
|
Failing CI is because I used |
squaremo
approved these changes
Aug 3, 2018
squaremo
left a comment
Collaborator
There was a problem hiding this comment.
This seems like a reasonable requirement, and neatly done. Thanks! Will merge if you get the tests to pass OK (yes, it's written in very old JS ...).
Contributor
Author
|
Fixed that use of Also, after re-reading my previous comment about the node versions, it may have came across as being a bit rude. If so, that was not my intent. :) |
Contributor
Author
|
I also rebased onto the latest master. |
This was referenced Dec 2, 2018
This was referenced Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This change adds a
methodIdandclassIdproperty to the channel errors.Motivation
I have a higher level configuration for the topology that allows automatic deletion of exchanges and queues. I perform a
deleteExchange/deleteQueuewithifUnused/ifEmptyoptions set, and against exchanges and queues that no longer exist. These operations will fail with an error in some cases. Currently it is only possible to determine if there was apreconditionfailederror code (406) and not what operation failed. In the case of bad topology, for example a binding to a queue that does not exist, I produces a critical error fault in our monitoring system. In the case of a failure to delete an exchange or queue, I want to ignore the error, but currently cannot. With this change, errors will contain the class and method IDs, so that the source and type of error can be determined.Notes
error.codecheck. I'm unsure on how or where to add any additional tests that may be needed.