fix(CallBatchLayer): don't batch if single request - #2397
Merged
DaniPopes merged 15 commits intoAug 19, 2025
Conversation
Ayushdubey86
requested review from
DaniPopes,
klkvr,
mattsse and
yash-atreya
as code owners
May 5, 2025 08:43
yash-atreya
changed the title
CallBatchLayer): don't batch if single request
DaniPopes
requested changes
May 7, 2025
Contributor
Author
|
Hello @DaniPopes pushed those changes, do check once free! |
DaniPopes
requested changes
May 8, 2025
Contributor
Author
|
Made those changes and pushed, do check @DaniPopes ! |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
DaniPopes
approved these changes
Aug 19, 2025
DaniPopes
enabled auto-merge (squash)
August 19, 2025 06:16
Rimeeeeee
pushed a commit
to Soubhik-10/alloy
that referenced
this pull request
Aug 25, 2025
* Raising Draft pr CallBatchLayer single request * Single Rpc Call * numbing testcase * numbing tc * numbing tc + fmt * fmt * Refactor+ adding tc * fmt * fmt * doc + removing clone * fmt * chore: clean up --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @mattsse @DaniPopes,
Raising a draft PR for #2386 — please let me know if the approach looks good.
I’m not converting to Multicall3 immediately upon receiving a request. Instead, I defer conversion until I’ve intercepted and counted the total number of calls. Based on that count, I either perform a normal RPC call (for a single request) or batch them using Multicall3.
I have numbed testcases as of now, if current approach is correct, I'll take on tc
Closes #2386.