add regExp option to address $data exploit via a regular expression (CVE-2025-69873) - #2590
Merged
Conversation
Closed
Contributor
|
@epoberezkin this should be targeting the v6 branch right? |
Member
Author
|
@G-Rath yes, and pushed some changes too |
G-Rath
approved these changes
Feb 18, 2026
1 task
|
Fundamentally it does not fix the issue unless users opt-in (most won't). I would consider using https://github.com/sindresorhus/super-regex or just reject ReDoS as vulnerability type like some other package authors do. |
cjnoname
approved these changes
Feb 19, 2026
Member
Author
@silverwind correct, but at least this PR allows to opt in, without it v6 has no option to configure regexp engine. |
Member
Author
|
6.14.0 released |
This was referenced Mar 7, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
What changes did you make?
Is there anything that requires more attention while reviewing?