fix(dev): close review report contract gaps#379
Merged
Conversation
Address four gaps an automated review flagged on the anti-slop redesign: - 03-review-relevancy regains its mandatory `## Output` (R8 action anatomy). - Single-axis runs: an axis not run marks the sections it owns "Not run" (functional owns Phases and Verification), never a placeholder or invented data, so review-code alone stays valid. - Unmet acceptance criteria tagged `fix` now also append a `functional` row to Findings, so the header count matches the verdict instead of reading 0. - Verdict: a `not-applicable` or `fixed` criterion no longer blocks `approve`; only an unchecked `fix` criterion does. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caeb8071a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Follow-up to the review-contract fixes, closing four consistency gaps: - Functional findings fill every Findings column (Location, Issue, Fix), not just phase and gap, so no row is blank or invented. - A functional `fix` row uses a blocking severity (critical or warning), never minor, so the header count always explains the verdict. - The router rule now states functional also appends its `fix` rows to Findings, matching the action. - The `blocked` rule carries the same tag exception as `approve`: a `not-applicable` or `fixed` criterion never blocks, whatever its severity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c09aaaa301
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Two more consistency gaps from review feedback: - A `fix` functional row uses 🔴 critical when the criterion itself is critical, otherwise 🟡 warning, so a blocked verdict never shows 0 critical. - The header carries `Axes run`, so a skipped code or relevancy axis is visible even though Findings is shared; a functional-only report no longer reads like a clean full review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four review-contract gaps flagged on #377: relevancy
## Output(R8); single-axis runs mark unrun sections "Not run"; unmetfixcriteria append afunctionalFindings row so count matches verdict;not-applicable/fixedno longer blockapprove. Validated with real e2e reviews (empty-diff, code-only, full).🤖 Generated with Claude Code