Skip to content

fix(decisioning): get_adcp_capabilities response must include account.supported_billing when seller claims media_buy #379

Description

@bokelley

Context

protocol/get-adcp-capabilities-response.json (lines 132-173) requires account.supported_billing to be present whenever the seller claims media_buy. The v3 reference seller declares:

DecisioningCapabilities(
    specialisms=("sales-non-guaranteed",),
    channels=("display", "video"),
    pricing_models=("cpm",),
)

…with no supported_billing declaration anywhere. Either the framework is silently projecting this from somewhere (e.g. BuyerAgent.billing_capabilities) and we should verify, or the framework is silently emitting an out-of-spec capabilities response.

Refs:

  • src/adcp/decisioning/capabilities.py
  • examples/v3_reference_seller/src/platform.py
  • protocol/get-adcp-capabilities-response.json:132-173

Acceptance Criteria

  • Audit current get_adcp_capabilities response — confirm whether account.supported_billing is populated
  • If missing: add it to DecisioningCapabilities (or wherever the projection happens) and wire through to the response
  • If BuyerAgent.billing_capabilities is the source, document that and ensure the v3 ref seller sets it
  • Schema-validate the capabilities response against get-adcp-capabilities-response.json in CI
  • Boot-time validator rejects platforms that claim media_buy without declaring supported_billing

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions