Skip to content

WriteAll: use delegate instead of Expression #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamhathcock merged 4 commits into from
Jul 27, 2022
Merged

WriteAll: use delegate instead of Expression #683

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2946a35
WriteAll: use delegate instead of Expression
OwnageIsMagic Jul 18, 2022
109a7c1
WriteAll: update delegate type
OwnageIsMagic Jul 19, 2022
5ca4efa
WriteAll: revert 109a7c1
OwnageIsMagic Jul 26, 2022
6476425
Merge branch 'master' into patch-1
adamhathcock Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SharpCompress/Writers/IWriterExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static void WriteAll(this IWriter writer, string directory, string search
public static void WriteAll(this IWriter writer,
string directory,
string searchPattern = "*",
Expression<Func<string, bool>>? fileSearchFunc = null,
Predicate<string>? fileSearchFunc = null,
SearchOption option = SearchOption.TopDirectoryOnly)
{
if (!Directory.Exists(directory))
Expand All @@ -49,10 +49,10 @@ public static void WriteAll(this IWriter writer,
{
fileSearchFunc = n => true;
}
foreach (var file in Directory.EnumerateFiles(directory, searchPattern, option).Where(fileSearchFunc.Compile()))
foreach (var file in Directory.EnumerateFiles(directory, searchPattern, option).Where(fileSearchFunc))
{
writer.Write(file.Substring(directory.Length), file);
}
}
}
}
}