Skip to content

This adds a test with a comma. - #32

Merged
lemire merged 3 commits into
mainfrom
adding_comma_test
Jul 21, 2023
Merged

This adds a test with a comma.#32
lemire merged 3 commits into
mainfrom
adding_comma_test

Conversation

@lemire

@lemire lemire commented Jul 21, 2023

Copy link
Copy Markdown
Member

This PR will fail if we fail to parse "128.0,0.1" without error (a comma is forbidden, but we are lenient).

@lemire

lemire commented Jul 21, 2023

Copy link
Copy Markdown
Member Author

The failing lint checks are not related to this PR.

@lemire
lemire requested a review from anonrig July 21, 2023 15:03
@lemire

lemire commented Jul 21, 2023

Copy link
Copy Markdown
Member Author

Issued a commit to fix pre-existing linter issue.

@lemire

lemire commented Jul 21, 2023

Copy link
Copy Markdown
Member Author

Merging.

@lemire
lemire merged commit 3a6c7b1 into main Jul 21, 2023
@lemire
lemire deleted the adding_comma_test branch July 21, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants