paginate over all changed files and sync and add "sync-labels" option to enable removing labels - #63
Conversation
When I run 'npm run build' it adds webpack code to dist/index.js every time. It changes the js file even in main.ts is not changed.
cbae117 to
bed0dae
Compare
|
Nice work on the "sync-labels" feature 👍 Perhaps it is an idea to limit this PR to just that feature to increase the likelihood of it being merged? Pagination is already implemented in #43 and should probably be merged there. Doing the formatting in this PR makes it difficult to review the meaningful changes in this PR (and causes unnecessary merge conflicts). |
|
I can rebase this later and see if the formatting is fixed on |
Makes sense. The formatting is not yet fixed on master, but it seems you will no longer get a failing build as a result of incorrect formatting. |
|
The other issue is that |
I can't help you with that, could be due to a variety of reasons. But I don't think it matters much. Merge conflicts in the dist/index.js file are straightforward to resolve by the maintainers of this action and don't affect reviewing the changes, so I wouldn't worry about it. |
|
Thanks for this, and sorry for the huge delay. The maintainership of this action has changed a few times so some older items like this fell off the radar I merged your changes via #96 to make it a little easier / faster as Im going through and cleaning up a bit |
Build process
masteris not formatted via thenpm run formatcommand. I see the same changes in other open PRs so I don't think this is isolated to just me.npm run buildit adds webpack-looking wrapper code todist/index.jsevery time. It changes the js file even in main.ts is not changed. I changed the build script toncc build ./src/main.tsto compile the TypeScript source directly and it seems to work better.dist/index.jsas well so this also does not seem isolated to just me.Fixes
dist/index.jsalso.Features
sync-labels: trueis given, the action will remove any labels when no matching files are modified. This closes Remove labels for reverted changes #14.