Paginate and remove old labels - #96
Merged
Merged
Conversation
This was referenced Sep 8, 2020
stevecotton
reviewed
Oct 12, 2020
| const configPath = core.getInput('configuration-path', {required: true}); | ||
| const token = core.getInput("repo-token", { required: true }); | ||
| const configPath = core.getInput("configuration-path", { required: true }); | ||
| const syncLabels = !!core.getInput("sync-labels", { required: false }); |
There was a problem hiding this comment.
sync-labels still triggering when set to false (bug #104), or when unset.
I think the bug is on this line - getInput returns a string, and !!"false" is true, just like !!"true".
There was a problem hiding this comment.
Doh! When I orginally wrote this code, I don't think I tested setting the input to false. You can just leave the input out to disable syncing as a workaround until this bug is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big thank you to @kevinphelps for #63 (closes #14) and @Co-qn for #43 (closes #42)
I just took those changes verbatim and rebased them and re-created this for simplicity. In the future I will ideally continue to merge existing PRs rather than create new ones but given their age I felt it reasonable to recreate them here so they'd be rebased, I could generate an up to date build, and run the formatting