Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

Allow sub domains by default when checking proxy bypass #40

Description

@Swiftwork

Currently the no_proxy environmental variable combined with checkBypass does not take into account sub domains. I don't know if this is by design, but an example of this is:

process.env['no_proxy'] = 'internal.com'
checkBypass(new Url('https://github.internal.com/path/to/repo')) // false

process.env['no_proxy'] = 'github.internal.com'
checkBypass(new Url('https://github.internal.com/path/to/repo')) // true

The offending line is:

if (upperReqHosts.some(x => x === upperNoProxyItem)) {

I would love to see a more lenient pattern, either respecting wildcards or ignoring sub domains.

Regards
Erik Hughes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions