ci: attach provenance and SBOM attestations to the published image - #1278
ci: attach provenance and SBOM attestations to the published image#1278kobihikri wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe container workflow enables maximum Docker provenance generation and SBOM output during image builds, while preserving the existing ChangesContainer image metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Correction — I got a fact wrong in this PR, and I would rather flag it myself than let it sit. I wrote that the pushed manifest "carries no provenance or SBOM attestation". That is half wrong, and the wrong half matters. Provenance is already there. For public repositories, The SBOM is genuinely new. That part stands — the same page says "SBOM attestations aren't automatically added to the image", and I also wrote in the caveats that So the honest description of this PR is: it adds an SBOM attestation, and pins the provenance mode explicitly instead of relying on the default. Both are still defensible — an explicit line means the behaviour will not change quietly if the default ever does — but it is a smaller change than my description implied, and you should judge it on that basis rather than on what I originally wrote. Happy to retitle and rewrite the description accordingly, or to close this if the SBOM alone is not worth the diff to you. Either is fine — just say which and I will act on it. Apologies for the inaccuracy. It was caught by a maintainer reviewing the same change on another project, and they were right to. |
Hi, and thanks for ACE-Step.
.github/workflows/container.ymlpublishes the image, but the pushed manifest carries no provenance or SBOM attestation. Someone pulling it cannot check that it was built by this workflow, from this repository, at that tag.The SBOM half is the useful one here: the image bundles a large model and audio stack, and publishing that inventory means it can be assessed without running the container first.
The change is two lines on the build step:
BuildKit attaches both to the image manifest, so they travel with the image. No permissions change is needed — nothing has to gain
id-token, and your tag and cache configuration are untouched.Two caveats worth stating:
mode=maxrecords the full build including build arguments, soprovenance: trueis the smaller option if any have ever been sensitive; and attestations add an extra manifest to the index, which the registry supports.No SLSA level claimed — the attestation is what BuildKit produces.
Disclosure: I used AI assistance to help spot this and prepare the change, and I read the workflow myself.
Summary by CodeRabbit