Skip to content

feat: add --config option to allow custom config file path#237

Merged
TimothyJones merged 1 commit intoabsolute-version:masterfrom
sameerthekhans:feature/custom-config-file-path
Aug 27, 2025
Merged

feat: add --config option to allow custom config file path#237
TimothyJones merged 1 commit intoabsolute-version:masterfrom
sameerthekhans:feature/custom-config-file-path

Conversation

@sameerthekhans
Copy link
Copy Markdown
Contributor

@sameerthekhans sameerthekhans commented Jul 13, 2025

Closes #236

Summary:

This pull request adds support for a --config option to allow users to specify a custom configuration file path.

Changes:

  • Adds a --config (-c) CLI argument using yargs.
  • Includes tests verifying that the custom config file is correctly parsed.
  • Updates documentation.

Copy link
Copy Markdown
Member

@TimothyJones TimothyJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one minor nitpick about the docs. Thanks for this!

Comment thread README.md Outdated
Comment thread lib/configuration.js Outdated
@sameerthekhans sameerthekhans force-pushed the feature/custom-config-file-path branch from 680300c to 5e7c6fd Compare August 27, 2025 12:20
@sameerthekhans
Copy link
Copy Markdown
Contributor Author

@TimothyJones Thank you for the review. I agree with your suggestion and have updated the code accordingly.

@TimothyJones
Copy link
Copy Markdown
Member

Awesome, thanks for the fast response! I'll get this in and released as soon as CI passes

Minor etiquette thing - it's best not to force push on reviewed branches - as it makes it hard to see what's changed since review. But this one was small enough to easily re-review so it doesn't actually matter.

Thanks again for the contribution, much appreciated!

@TimothyJones TimothyJones merged commit 3958e68 into absolute-version:master Aug 27, 2025
6 checks passed
@TimothyJones
Copy link
Copy Markdown
Member

Released in 12.6.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Support --config CLI option to load configuration from a custom path

2 participants