fix: use fast-xml-parser to parse and build XML. This substantially reduces the bundle size.

[nyarthan]

jsdom is quite a heavy library just to parse some XML content. (2.7MB minified) This replaces it with the parser of fast-xml-parser.

Since the result is a plain JS Object instead of a DOM node, we can also use the corresponding XMLBuilder.

The resulting XML is formatted differently (no empty lines between sibling tags), hence the failing tests. Since the previous solution also did not preserve formatting I think this is a reasonable side-effect. But I'm curious how this should be handled.

[TimothyJones]

Hi! Thanks for this, and apologies for the delay.

Probably we should run the xml through a formatter before testing to avoid this kind of issue in the future.

The easy option here is we can just update the snapshots - I don't think the specific format should be part of the contract of the library.

[nyarthan]

Hi! Thanks for this, and apologies for the delay.

Probably we should run the xml through a formatter before testing to avoid this kind of issue in the future.

The easy option here is we can just update the snapshots - I don't think the specific format should be part of the contract of the library.

Thanks for the feedback - I updated the format of the fixtures.
I also think having formatters in/before the tests would make sense but it seems to me to be out of scope for this PR

[nyarthan]

@TimothyJones are you still interested in getting this change merged? No pressure - I was just doing some housekeeping and would close this if there is no interest.

[TimothyJones]

Oh! Thanks for the reminder, yes, I’m keen to merge it, must have missed the notification somehow. Will take a look today

[TimothyJones]

Released as 12.6.1