fix: ignore other prerelease tags when finding latest tag#213
Merged
TimothyJones merged 1 commit intoabsolute-version:masterfrom Apr 9, 2025
Merged
fix: ignore other prerelease tags when finding latest tag#213TimothyJones merged 1 commit intoabsolute-version:masterfrom
TimothyJones merged 1 commit intoabsolute-version:masterfrom
Conversation
Member
|
Thanks for this! Would you be able to add documentation for it to the readme, please? |
Contributor
Author
|
Thanks! As for documentation, I am not sure what would be useful. I guess we could say in https://github.com/absolute-version/commit-and-tag-version?tab=readme-ov-file#release-as-a-pre-release something like "you can use different prerelease names" (too obvious?) or then add an example block for beta release (but that would would pretty much identical to the block for the alpha release). Any ideas? |
Member
|
Good point, this is probably just how people would expect it to work. |
Member
|
Released in 12.5.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to issue #211
If we have already git tags:
and then try to determine the next tag for prerelease
a, we getv1.0.0-a.0(which already exists).This is because
lib/latest-semver-tag.jswas returning the latest tag, even if it was different prerelease (bin this case).This PR adds filtering to remove prerelease tags for different prereleases, and only then selecting latest