Doesn't list commits inside a changelog due to version mismatches

[Janiczek]

Describe the bug

• The dependency conventional-changelog-core@5.0.2 creates a CPS-style transform function (never returns, calls cb(null, commit))
• The dependency conventional-changelog-writer@6.0.1 tries to use it in a non-CPS style (commit = transform(commit, context), resulting in commit being null)
• The result is that an empty array of commits is given to the CHANGELOG.md generator, and that returns

## [0.0.221](https://github.com/AUTHOR/REPO/compare/v0.0.220...v0.0.221) (2024-11-26)

without any commits listed.

Current behavior
No commits are listed in the generated CHANGELOG.md

Expected behavior
Commits are listed in the generated CHANGELOG.md

Environment

• commit-and-tag-version version(s): 12.5.0
• Node/npm version: Node v20.18.1, NPM v10.8.2
• OS: Ubuntu 22.04.5 LTS (Github Actions runner)

Possible Solution

Hopefully updating conventional-changelog to something new-ish (currently used version is 4.0.0 while the newest version seems to be 6.0.0 according to npmjs.com) would help? I haven't tried this.

Looking at the current master version of conventional-changelog:

• core still uses CPS in mergeConfig
• writer has been substantially rewritten and the closest code seems to be here, though it looks like it has the same bug. Maybe I'm missing some promisification happening elsewhere.

Additional context
I'm using commit-and-tag-version from within projen@0.88.0. It lists

    "commit-and-tag-version": "^12",

as a dependency automatically for all TS projects.

[Janiczek]

Just realized that perhaps I don't have the full story here because the transform fn from mergeOptions doesn't even get run. So maybe it's a red herring

[Janiczek]

The way for me to make commit-and-tag-version work properly was to patch-package this code out:

as I haven't found a way to set transform: null or something similar in the writerOpts that would work in the same way.

[TimothyJones]

Is that a patch for conventional-changelog-core ? It's not super clear to me, but it doesn't look like code from this repository.

I'm keen to get the core updated - but it needs a migration to ESM, so it's not a small amount of work.

[Janiczek]

The highlighted code is from conventional-changelog-writer 6.0.1, to be specific.

[KristjanESPERANTO]

I have the same issue with commit-and-tag-version v12.5.0 on node 23.

[TimothyJones]

Thanks. I'm going to look at the ESM conversion later this month, which should allow us to update all the dependencies.