BUILD files and tests folder included in wheel

[andersdyhrnorlov]

In version 2.2.0 and 2.2.1 it seems like the tests folder and your internal BUILD files for bazel are included. I don't know why it has happened as it seems like the setup.py actually tries to exclude tests folders.

The inclusion of the BUILD files breaks our bazel repo when we use absl test as a dependency.

Reproduce: Download whl for 2.2.0 and 2.2.1 and see tests folder and BUILD files, download 2.0.0 and see no tests folder and no BUILD files.

[dougthor42]

Possibly related: the runfiles directory does not include the source code, only the dist info metadata, when using 2.2.x as a dependency:

$ tree -L 3 bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
├── __init__.py
└── site-packages
    ├── absl_py-2.2.1.dist-info
    │   ├── AUTHORS -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/AUTHORS
    │   ├── INSTALLER -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/INSTALLER
    │   ├── LICENSE -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/LICENSE
    │   ├── METADATA -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/METADATA
    │   ├── top_level.txt -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/top_level.txt
    │   └── WHEEL -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/WHEEL
    └── __init__.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/__init__.py

3 directories, 8 files

$ tree -L 3 bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
├── __init__.py
└── site-packages
    ├── absl
    │   ├── app.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/app.py
    │   ├── app.pyi -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/app.pyi
    │   ├── command_name.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/command_name.py
    │   ├── flags
    │   ├── __init__.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/__init__.py
    │   ├── logging
    │   ├── __pycache__
    │   └── testing
    ├── absl_py-2.1.0.dist-info
    │   ├── AUTHORS -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/AUTHORS
    │   ├── INSTALLER -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/INSTALLER
    │   ├── LICENSE -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/LICENSE
    │   ├── METADATA -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/METADATA
    │   ├── top_level.txt -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/top_level.txt
    │   └── WHEEL -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/WHEEL
    └── __init__.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/__init__.py

8 directories, 12 files

[andersdyhrnorlov]

Possibly related: the runfiles directory does not include the source code, only the dist info metadata, when using 2.2.x as a dependency:

$ tree -L 3 bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
├── __init__.py
└── site-packages
    ├── absl_py-2.2.1.dist-info
    │   ├── AUTHORS -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/AUTHORS
    │   ├── INSTALLER -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/INSTALLER
    │   ├── LICENSE -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/LICENSE
    │   ├── METADATA -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/METADATA
    │   ├── top_level.txt -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/top_level.txt
    │   └── WHEEL -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.2.1.dist-info/WHEEL
    └── __init__.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/__init__.py

3 directories, 8 files

$ tree -L 3 bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
bazel-bin/absl-issue_bin.runfiles/rules_python~~pip~pip_311_absl_py/
├── __init__.py
└── site-packages
    ├── absl
    │   ├── app.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/app.py
    │   ├── app.pyi -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/app.pyi
    │   ├── command_name.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/command_name.py
    │   ├── flags
    │   ├── __init__.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl/__init__.py
    │   ├── logging
    │   ├── __pycache__
    │   └── testing
    ├── absl_py-2.1.0.dist-info
    │   ├── AUTHORS -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/AUTHORS
    │   ├── INSTALLER -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/INSTALLER
    │   ├── LICENSE -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/LICENSE
    │   ├── METADATA -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/METADATA
    │   ├── top_level.txt -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/top_level.txt
    │   └── WHEEL -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/absl_py-2.1.0.dist-info/WHEEL
    └── __init__.py -> /usr/local/google/home/dthor/.cache/bazel/_bazel_dthor/63213d34dddb07b3ab09f9059339f08a/external/rules_python~~pip~pip_311_absl_py/site-packages/__init__.py

8 directories, 12 files

Yes this is exactly the issue. I've tested it, and the source files are in the python deps in our bazel repo, but they don't get into the runfiles because the BUILD files are included. When deleting the BUILD files manual from the wheel everything works as before.

[aignas]

FYI, it is really nice to use this wheel browser, which explained the failing PR we had in rules_python bazel-contrib/rules_python#2717.

See
https://pypi-browser.org/package/absl-py/absl_py-2.2.1-py3-none-any.whl/absl_py-2.2.1.dist-info/RECORD#L1

[al-bus]

Thank you for your bug report! We just released the 2.2.2 version without BUILD and tests files. Feel free to try if the issue is gone.

[AleksMat]

Tagged a new version: https://github.com/abseil/abseil-py/releases/tag/v2.2.2