Skip to content

Download network --template-source instead of reading it as a local file#25670

Merged
maliming merged 1 commit into
rel-10.5from
maliming/cli-network-template-source
Jun 23, 2026
Merged

Download network --template-source instead of reading it as a local file#25670
maliming merged 1 commit into
rel-10.5from
maliming/cli-network-template-source

Conversation

@maliming

Copy link
Copy Markdown
Member

Network --template-source was read as a local file (File.ReadAllBytes) instead of being downloaded, so pulling a template from a URL failed. It now falls through to the HTTP download; a local source also accepts a direct .zip file path and --skip-cache is honored.

Refs #24814

@maliming
maliming requested a review from yekalkan June 23, 2026 01:58
@maliming maliming added this to the 10.5-final milestone Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.35%. Comparing base (ce39453) to head (b3a5263).
⚠️ Report is 30 commits behind head on rel-10.5.

Files with missing lines Patch % Lines
...lo/Abp/Cli/ProjectBuilding/AbpIoSourceCodeStore.cs 0.00% 5 Missing ⚠️
.../Abp/Cli/ProjectBuilding/TemplateProjectBuilder.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.5   #25670      +/-   ##
============================================
- Coverage     49.35%   49.35%   -0.01%     
============================================
  Files          3687     3687              
  Lines        124432   124430       -2     
  Branches       9507     9506       -1     
============================================
- Hits          61418    61417       -1     
+ Misses        61174    61171       -3     
- Partials       1840     1842       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming
maliming merged commit 6b4136a into rel-10.5 Jun 23, 2026
3 of 4 checks passed
@maliming
maliming deleted the maliming/cli-network-template-source branch June 23, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants