[FIX] Multiple parameters for route_v8#84
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 92.98% 92.99%
=======================================
Files 26 26
Lines 1754 1755 +1
=======================================
+ Hits 1631 1632 +1
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| __copyright__ = "Copyright (c) 2017 Abdullah Selek" | ||
| __license__ = "MIT License" | ||
| __version__ = "3.6.4" | ||
| __version__ = "3.6.5" |
There was a problem hiding this comment.
I don't think we need to bump the version as 3.6.4 is not released yet.
There was a problem hiding this comment.
Sorry! I also bumped the version in #82 ...
| for key, value in parameters.items(): | ||
| if isinstance(value, dict): | ||
| for key2, val2 in value.items(): | ||
| res[f"{key}[{key2}]"] = val2 |
There was a problem hiding this comment.
Please format the code, I can see an extra space before val2. And also use better variable names for key2 and val2.
There was a problem hiding this comment.
Done, thanks.
eaeca38 to
918b954
Compare
918b954 to
e1e01ff
Compare
abdullahselek
left a comment
abdullahselek
left a comment
There was a problem hiding this comment.
Thanks for the fixes! Looks good to me.
3 participants
encode_parametersmethod, so it processes dict parameters correctly. Here API expects multi-level dict to be expressed askey[sub1]=val1&key[sub2]=val2. The method supports only one level sub-dict, which as far as I know, should be enough.route_v8-avoid,excludeandtruckparameters were not fully supported.Fixes #83