chore: Rerun flaky tests on CI if they failed#905
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a flaky-test-retry Maven profile to automatically retry tests tagged with @Tag("flaky") up to three times, and applies this tag to several tests in AbstractA2AServerTest.java. However, the current implementation auto-activates this profile for any module containing src/test/java, which introduces significant build performance overhead due to redundant Surefire executions and causes dependency pollution by forcing modules without JUnit tests to include junit-jupiter-api. It is recommended to either define the profile locally within the specific modules that have flaky tests or disable the execution by default and enable it selectively.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a flaky test retry mechanism by defining a new Maven profile flaky-test-retry in the root pom.xml. This profile configures the maven-surefire-plugin to run standard tests and flaky tests separately, retrying the latter up to three times. The profile is activated in several sub-module pom.xml files using the contains.flaky.tests property, and several tests in AbstractA2AServerTest.java are annotated with @Tag("flaky"). There are no review comments, and I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a retry mechanism for flaky tests by defining a new Maven profile flaky-test-retry in the root pom.xml and tagging several tests in AbstractA2AServerTest.java as @Tag("flaky"). However, the reviewer identified a critical issue: Maven profile activation occurs before POM properties are processed, meaning the profile will never be activated by the <contains.flaky.tests> property defined in the submodules. To resolve this, the reviewer suggested making the profile active by default and controlling the execution behavior via property overrides in the submodules.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to retry flaky tests. A new Maven profile flaky-test-retry is added to pom.xml, which is activated in modules containing a .flaky-tests-marker file. This profile configures the maven-surefire-plugin to run non-flaky tests first, and then run flaky tests with up to three retries. Marker files have been added to several test modules, and the @Tag("flaky") annotation has been applied to several flaky tests in AbstractA2AServerTest.java. There are no review comments, and I have no additional feedback to provide.
Use the @tag("flaky") annotation to mark flaky tests
…it-jupiter-api dependency where not needed
1 participant
Use the @tag("flaky") annotation to mark flaky tests