Skip to content

Fix compile error on OLED disabled - #304

Merged
koron merged 1 commit into
Yowkees:mainfrom
MiSawa:fix/no-oled
Sep 16, 2023
Merged

Fix compile error on OLED disabled#304
koron merged 1 commit into
Yowkees:mainfrom
MiSawa:fix/no-oled

Conversation

@MiSawa

@MiSawa MiSawa commented Aug 12, 2023

Copy link
Copy Markdown
Contributor

When one attempted to build the firmware with OLED feature disabled, following compile errors are thrown.

keyboards/keyball/lib/keyball/keyball.c:69:20: error: ‘format_4d’ defined but not used [-Werror=unused-function]
Compiling: keyboards/keyball/lib/keyball/keyball.c                                                  [ERRORS]
 static const char *format_4d(int8_t d) {
                    ^
keyboards/keyball/lib/keyball/keyball.c:96:13: error: ‘to_1x’ defined but not used [-Werror=unused-function]
 static char to_1x(uint8_t x) {
             ^

These two functions are used only under #ifdef OLED_ENABLE guard, and thus have to be guarded as well.

@Yowkees
Yowkees requested a review from koron September 14, 2023 23:50
@koron

koron commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

I'll check and merge this after upgrading QMK 0.22.

Thank you!

@koron koron self-assigned this Sep 16, 2023
@koron
koron merged commit d873e32 into Yowkees:main Sep 16, 2023
@koron

koron commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

confirmed on local.

@MiSawa
MiSawa deleted the fix/no-oled branch September 16, 2023 07:22
koron added a commit to koron/qmk_firmware that referenced this pull request Sep 16, 2023
Yasnen pushed a commit to Yasnen/keyball that referenced this pull request Feb 28, 2026
Fix compile error on OLED disabled
CinewhoopTokyo pushed a commit to CinewhoopTokyo/keyball that referenced this pull request Aug 12, 2026
Fix compile error on OLED disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants