Skip to content

Use tbb::affinity_partitioner according to documentation - #338

Draft
FabienPean-Virtonomy wants to merge 1 commit into
Xiangyu-Hu:masterfrom
Virtonomy:fix/affinity-partitioner
Draft

Use tbb::affinity_partitioner according to documentation#338
FabienPean-Virtonomy wants to merge 1 commit into
Xiangyu-Hu:masterfrom
Virtonomy:fix/affinity-partitioner

Conversation

@FabienPean-Virtonomy

Copy link
Copy Markdown
Collaborator

@DrChiZhang

Copy link
Copy Markdown
Collaborator

How about the improvement of this modification?

@FabienPean-Virtonomy

Copy link
Copy Markdown
Collaborator Author

I assume close to nil. Previous version was creating an affinity_partitioner for each translation unit which is pretty close to this. This may have had an impact when the affinity partitioner object is used multiple times in different algorithms within the same source file. I just tried to follow the documentation for the recommended use of this feature.

If we trust solely the CI (which is not really representative of actual load because of using 2/3 cores only) then it seemingly gets worse for macOS based on a single sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants