Remove redundant paragonie/random_compat dependency#155
Open
brendt wants to merge 2 commits into
Open
Conversation
boring-cyborg
Bot
added
Dependencies 📦
WyriHaximus
requested changes
Apr 4, 2026
WyriHaximus
left a comment
WyriHaximus
left a comment
Owner
There was a problem hiding this comment.
Hey and thanks for taking the time to put this PR together. While @paragonie-security makes a great point, at this point I'm more in favour of dropping this and adding ext-libsodium as a hard requirement for this package. Could you also include the updated composer.lock with the changeset, thanks.
Author
|
@WyriHaximus Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package depends on
paragonie/random_compat: ^9.0 || ^2.0, but alsophp: ^8 || ^7.4. Sincerandom_bytesandrandom_intwere added in PHP 7.0, the dependency onparagonie/random_compatseems redundant?