UI: Add Combobox and Autocomplete Status - #82195
Conversation
|
Size Change: +59 B (0%) Total Size: 7.92 MB 📦 View Changed
|
|
Flaky tests detected in 3f7eca6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/33426202645 As a user I want to be able to customize the navigation overlay with styled content in
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| <Autocomplete.Status ref={ statusRef }> | ||
| Loading... | ||
| </Autocomplete.Status> |
There was a problem hiding this comment.
Should we also check that the rendered node has role="status", aria-live="polite", and aria-atomic="true"? Or do we delegate / trust base ui on this? (the current ref assertion would also pass for a plain <div>, so it does not protect the accessible behavior these subcomponents add)
What?
Adds
Combobox.StatusandAutocomplete.Statussubcomponents that wrap the Base UIStatusprimitive.This PR does not add
Statusto higher-level components such asSearchableChipSelectorSelectControl. Those can take it in a follow-up.Why?
AutocompleteandComboboxhad no way to announce async list status.How?
Thin wrappers matching
Empty.Tests cover ref forwarding. Keep-mounted live region behavior is Base UI, not something we retest here.
Testing Instructions
role="status"node stays in the DOM after the message clears.