Storybook: Drop unused support for js-as-jsx - #82192
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.91 MB |
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
Looks like we could also remove js from the components E2E story glob in test/storybook-playwright/storybook/main.ts?
Yep, good catch. Updated in b1ce81c and confirmed there were no existing |
|
Flaky tests detected in b1ce81c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/33390690614 As a user I want to be able to create a navigation overlay for a specific navigation block in
|
What?
Removes Storybook configuration that exists to support stories being written as
.jsfiles.Related: #80855, #80990, #74396
Why?
This was originally added as part of the Storybook v10 upgrade in #74396, where Vite requires
.jsxextension, but many of our stories were written as.js. Since this is no longer the case after #80990 and we expect all stories to have.jsxor.tsxfile extensions, we don't need this additional support or detection for.jsfiles. This is further guaranteed by linting added in #80123 that requires all new files with JSX syntax to use the.tsxfile extension.Testing Instructions
Storybook should build and run as normal:
Use of AI Tools
Used Claude Code + Opus 5 to understand what was or wasn't required here and implement updates, which were then reviewed by myself.