Breadcrumb: Add UI component - #80425
Conversation
|
Size Change: +3.25 kB (+0.04%) Total Size: 7.92 MB 📦 View Changed
|
|
Flaky tests detected in 06abee7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/33389075567 Should navigate inner blocks with arrow keys in
|
06fb630 to
3e8c6ef
Compare
e00ad0b to
144ec3a
Compare
a86c4a2 to
6540444
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @abd-RAHEEM. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Also cc @grbicsanja as she co-authored the initial specs in #76709 |
mirka
left a comment
There was a problem hiding this comment.
Could you also take another look at the common.css defense? Some of our styles seem to be losing.
ec5a429 to
ffaf751
Compare
ffaf751 to
3dbbaa3
Compare
Extended the global CSS defense to I also applied a few smaller improvements:
|
|
Edit: this is actually a non-issue, since the "current" page will never end up in the collapsed menu by design. |
mirka
left a comment
There was a problem hiding this comment.
The ol/li defense covers the remaining common.css rules that hit this DOM. ol { list-style-type: decimal; margin-left: 2em }, ul, ol { padding: 0 }, and li, dd { margin-bottom: 6px }. I don't see another unlayered admin selector that would still win on the breadcrumb tree.
Earlier notes look addressed. Type export, openInNewTab, jest-console, and the use-with-caution manifest tag.
|
Thank you! Given that is not recommended (and not used anywhere), we can merge and iterate as we go. @simison , let's coordinate re. next steps in using |
|
Woah, I'm experimenting with some new agent setups and it did an approval post without my explicit permission 😅 In this case it was fine, but I'll add some guardrails for this. Sorry if the text read as less human than usual. |
|
No worries about it, we're all experimenting with new tools. Please leave feedback if you have more and I'll follow-up in a new PR. |
What?
Closes #77039.
Adds a responsive
Breadcrumbcompound component to@wordpress/ui.Why?
Consumers need a routing-agnostic breadcrumb trail that remains usable when space is limited.
How?
Breadcrumb.Root,Breadcrumb.LinkItem, andBreadcrumb.CurrentItemAPI from the singularbreadcrumbsource module.Menuwhile keeping the current item visible.Buttonfor overflow and shared component styles in the inert measurement copy.Testing Instructions
npm run storybook:devand open Design System / Components / Breadcrumb.Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2026-07-17.at.23.25.25.mp4
Use of AI Tools
Codex assisted with implementation, tests, and self-review. I reviewed and verified the changes locally.